netdev - Re: [PATCH net] ravb: Double free on error in ravb_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170424.135905.515581977383181185.davem@davemloft.net>
Date:   Mon, 24 Apr 2017 13:59:05 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     dan.carpenter@...cle.com
Cc:     sergei.shtylyov@...entembedded.com,
        kazuya.mizuguchi.ks@...esas.com, horms+renesas@...ge.net.au,
        ykaneko0929@...il.com, masaru.nagai.vx@...esas.com,
        geert+renesas@...der.be, niklas.soderlund+renesas@...natech.se,
        tremyfr@...il.com, netdev@...r.kernel.org,
        linux-renesas-soc@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net] ravb: Double free on error in ravb_start_xmit()

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Sat, 22 Apr 2017 13:46:56 +0300

> If skb_put_padto() fails then it frees the skb.  I shifted that code
> up a bit to make my error handling a little simpler.
> 
> Fixes: a0d2f20650e8 ("Renesas Ethernet AVB PTP clock driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied.