netdev - Re: [PATCH net-next v5 1/2] net sched actions: dump more than TCA_ACT_MAX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170424.163033.797679814568299306.davem@davemloft.net>
Date:   Mon, 24 Apr 2017 16:30:33 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     jhs@...atatu.com
Cc:     simon.horman@...ronome.com, jiri@...nulli.us,
        xiyou.wangcong@...il.com, eric.dumazet@...il.com,
        netdev@...r.kernel.org, tom@...bertland.com, pablo@...filter.org
Subject: Re: [PATCH net-next v5 1/2] net sched actions: dump more than
 TCA_ACT_MAX_PRIO actions per batch

From: Jamal Hadi Salim <jhs@...atatu.com>
Date: Mon, 24 Apr 2017 08:49:00 -0400

> Yes, space is important and if i can express upto 32 flags
> with one TLV rather than 32 TLVs i choose one TLV.

Which is fine.  But two things:

1) Again, bits you aren't using now, make sure userspace doesn't
   set them.  And if it does, reject.

2) If you are worried about performance, we're talking about a TLV in
   the request here not the dump response itself so performance isn't
   a real issue as Pablo mentioned.