netdev - RE: [PATCH net-next 3/3] samples/bpf: check before defining offsetof

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6DCFFDAD25@AcuExch.aculab.com>
Date:   Tue, 25 Apr 2017 14:27:16 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Daniel Borkmann' <daniel@...earbox.net>,
        Alexander Alemayhu <alexander@...mayhu.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "ast@...com" <ast@...com>
Subject: RE: [PATCH net-next 3/3] samples/bpf: check before defining offsetof

From: Daniel Borkmann
> Sent: 24 April 2017 15:41
> To: Alexander Alemayhu; netdev@...r.kernel.org
> Cc: ast@...com
> Subject: Re: [PATCH net-next 3/3] samples/bpf: check before defining offsetof
> 
> On 04/24/2017 03:31 PM, Alexander Alemayhu wrote:
> > Fixes the following warning
> >
> > samples/bpf/test_lru_dist.c:28:0: warning: "offsetof" redefined
> >   #define offsetof(TYPE, MEMBER) ((size_t)&((TYPE *)0)->MEMBER)
> >
> > In file included from ./tools/lib/bpf/bpf.h:25:0,
> >                   from samples/bpf/libbpf.h:5,
> >                   from samples/bpf/test_lru_dist.c:24:
> > /usr/lib/gcc/x86_64-redhat-linux/6.3.1/include/stddef.h:417:0: note: this is the location of the
> previous definition
> >   #define offsetof(TYPE, MEMBER) __builtin_offsetof (TYPE, MEMBER)
> >
> > Signed-off-by: Alexander Alemayhu <alexander@...mayhu.com>
> 
> Acked-by: Daniel Borkmann <daniel@...earbox.net>

Isn't the correct fix to include stddef.h ?

	David