netdev - Re: [PATCH net-next v3 2/5] virtio-net: transmit napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF=yD-KJ_nFzOmOtmeUYXiO_+xO2yWB8xn_-jEm9zgycYzPOzQ@mail.gmail.com>
Date:   Tue, 25 Apr 2017 10:32:45 -0400
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Jason Wang <jasowang@...hat.com>
Cc:     Network Development <netdev@...r.kernel.org>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        virtualization@...ts.linux-foundation.org,
        David Miller <davem@...emloft.net>,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net-next v3 2/5] virtio-net: transmit napi

On Tue, Apr 25, 2017 at 4:36 AM, Jason Wang <jasowang@...hat.com> wrote:
>
>
> On 2017年04月25日 01:49, Willem de Bruijn wrote:
>>
>> @@ -1371,8 +1419,10 @@ static int virtnet_close(struct net_device *dev)
>>         /* Make sure refill_work doesn't re-enable napi! */
>>         cancel_delayed_work_sync(&vi->refill);
>>   -     for (i = 0; i < vi->max_queue_pairs; i++)
>> +       for (i = 0; i < vi->max_queue_pairs; i++) {
>>                 napi_disable(&vi->rq[i].napi);
>> +               napi_disable(&vi->sq[i].napi);
>> +       }
>
>
> Looks like this will wait for ever if napi_tx is false because we never
> enable the NAPI so we will wait for NAPI_STATE_SCHED to be cleared.

Indeed, thanks! I'll send a fix.