netdev - Re: [PATCH net v1 1/2] tipc: fix socket flow control accounting error at tipc_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170425.114552.1090114347611764286.davem@davemloft.net>
Date:   Tue, 25 Apr 2017 11:45:52 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     parthasarathy.bhuvaragan@...csson.com
Cc:     netdev@...r.kernel.org, tipc-discussion@...ts.sourceforge.net
Subject: Re: [PATCH net v1 1/2] tipc: fix socket flow control accounting
 error at tipc_send_stream

From: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@...csson.com>
Date: Mon, 24 Apr 2017 15:00:42 +0200

> Until now in tipc_send_stream(), we return -1 when the socket
> encounters link congestion even if the socket had successfully
> sent partial data. This is incorrect as the application resends
> the same the partial data leading to data corruption at
> receiver's end.
> 
> In this commit, we return the partially sent bytes as the return
> value at link congestion.
> 
> Fixes: 10724cc7bb78 ("tipc: redesign connection-level flow control")
> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@...csson.com>
> Reviewed-by: Jon Maloy <jon.maloy@...csson.com>

Both patches #1 and #2 applied, thanks.