netdev - Re: [PATCH net-next] rhashtable: remove insecure_max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170425110415.GA25167@gondor.apana.org.au>
Date:   Tue, 25 Apr 2017 19:04:15 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Florian Westphal <fw@...len.de>
Cc:     netdev@...r.kernel.org, fw@...len.de
Subject: Re: [PATCH net-next] rhashtable: remove insecure_max_entries param

Florian Westphal <fw@...len.de> wrote:
> no users in the tree, insecure_max_entries is always set to
> ht->p.max_size * 2 in rhtashtable_init().
> 
> Replace only spot that uses it with a ht->p.max_size check.

I'd suggest that as this needs to be computed every time we insert
an element that you keep the value in struct rhashtable, but as an
internal value as opposed to a paramter that is set by the user.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt