netdev - Re: TCP fast open using experimental TCP option?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALx6S35e2_92sYUR88YO10m_OhseeTjTr-nGWvpairOAY0_APQ@mail.gmail.com>
Date:   Tue, 25 Apr 2017 17:39:31 -0700
From:   Tom Herbert <tom@...bertland.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Jerry Chu <hkchu@...gle.com>
Subject: Re: TCP fast open using experimental TCP option?

On Tue, Apr 25, 2017 at 5:13 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> On Tue, 2017-04-25 at 12:08 -0700, Tom Herbert wrote:
>> Looks like TCP fast open was using experimental TCP option at some. Is
>> this still needed? Technically this violates usage requirements of
>> experimental options. Can this be removed now since there is now an
>> assigned option number for TFO?
>>
>>                              case TCPOPT_EXP:
>>                                 /* Fast Open option shares code 254 using a
>>                                  * 16 bits magic number.
>>                                  */
>>                                 if (opsize >= TCPOLEN_EXP_FASTOPEN_BASE &&
>>                                     get_unaligned_be16(ptr) ==
>>                                     TCPOPT_FASTOPEN_MAGIC)
>>                                         tcp_parse_fastopen_option(opsize -
>>                                                 TCPOLEN_EXP_FASTOPEN_BASE,
>>                                                 ptr + 2, th->syn, foc, true);
>>                                 break;
>
> Hi Tom
>
> Client side was updated in linux-4.1 only two years ago.
>
> We lack counters telling how often the experimental option is used.
>
> RFC6994 ( 5.  Migration to Assigned Options ) guidelines are properly
> met.
>
> Not sure why we should hurry ?
>
An IETFer was complaining that Linux indiscriminately violates TCP
RFCs and gave the use of experimental options as example. Yuchung
pointed out that this use is actually conformant to the spec so we're
good (thanks Yuchung!).

Tom

>