netdev - Re: [PATCH v2 net-next] bridge: add per-port broadcast flood flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <377cfb2f-dced-b164-6b7d-80ce2b5c7599@cumulusnetworks.com>
Date:   Wed, 26 Apr 2017 17:19:31 +0300
From:   Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:     Mike Manning <mmanning@...cade.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next] bridge: add per-port broadcast flood flag

On 26/04/17 16:48, Mike Manning wrote:
> Support for l2 multicast flood control was added in commit b6cb5ac8331b
> ("net: bridge: add per-port multicast flood flag"). It allows broadcast
> as it was introduced specifically for unknown multicast flood control.
> But as broadcast is a special case of multicast, this may also need to
> be disabled. For this purpose, introduce a flag to disable the flooding
> of received l2 broadcasts. This approach is backwards compatible and
> provides flexibility in filtering for the desired packet types.
> 
> Cc: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> Signed-off-by: Mike Manning <mmanning@...cade.com>
> ---
>  include/linux/if_bridge.h    |  1 +
>  include/uapi/linux/if_link.h |  1 +
>  net/bridge/br_forward.c      | 24 +++++++++++++++++-------
>  net/bridge/br_if.c           |  2 +-
>  net/bridge/br_netlink.c      |  3 +++
>  net/bridge/br_sysfs_if.c     |  2 ++
>  6 files changed, 25 insertions(+), 8 deletions(-)
> 

Thank you, now we can control all types.

Reviewed-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>