netdev - Re: blocking ops when !TASK_RUNNING in vsock_stream

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM_iQpXg-L2XOQfb_+Nngw7Qt0nh6Gy9nqBir0B3Ht3PjMKKmg@mail.gmail.com>
Date:   Wed, 26 Apr 2017 10:18:57 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     Claudio Imbrenda <imbrenda@...ux.vnet.ibm.com>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Andy King <acking@...are.com>,
        George Zhang <georgezhang@...are.com>
Subject: Re: blocking ops when !TASK_RUNNING in vsock_stream_sendmsg() (again)

Hi,

On Fri, Apr 21, 2017 at 1:14 AM, Michal Kubecek <mkubecek@...e.cz> wrote:
> I tried to think about a solution but there doesn't seem to be an easy
> way to fix this in vmw_stream_sendmsg() as moving prepare_to_wait()
> inside the loop would result in missed wake-ups (that was the problem
> with the original fix); IMHO the right way to resolve the issue would be
> rewriting the vmci queue pair code to allow performing the has_space()
> check without taking a mutex.


Can you try the attached patch (compile only)?

Thanks.

View attachment "vsock-wait.diff" of type "text/plain" (2095 bytes)