netdev - Re: [PATCH net-next] tcp: tcp_rack_reo_timeout() must update tp->tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170427.114646.1132727678105640160.davem@davemloft.net>
Date:   Thu, 27 Apr 2017 11:46:46 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, soheil@...gle.com, ncardwell@...gle.com,
        ycheng@...gle.com
Subject: Re: [PATCH net-next] tcp: tcp_rack_reo_timeout() must update
 tp->tcp_mstamp

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 26 Apr 2017 21:10:55 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> I wrongly assumed tp->tcp_mstamp was up to date at the time
> tcp_rack_reo_timeout() was called.
> 
> It is not true, since we only update tcp->tcp_mstamp when receiving
> a packet (as initially done in commit 69e996c58a35 ("tcp: add
> tp->tcp_mstamp field")
> 
> tcp_rack_reo_timeout() being called by a timer and not an incoming
> packet, we need to refresh tp->tcp_mstamp
> 
> Fixes: 7c1c7308592f ("tcp: do not pass timestamp to tcp_rack_detect_loss()")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks Eric.