netdev - Re: [PATCH net-next] rhashtable: Do not lower max_elems when max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170428.101449.1468521013732143831.davem@davemloft.net>
Date:   Fri, 28 Apr 2017 10:14:49 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     herbert@...dor.apana.org.au
Cc:     f.fainelli@...il.com, netdev@...r.kernel.org, fw@...len.de,
        tgraf@...g.ch
Subject: Re: [PATCH net-next] rhashtable: Do not lower max_elems when
 max_size is zero

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Fri, 28 Apr 2017 14:10:48 +0800

> The commit 6d684e54690c ("rhashtable: Cap total number of entries
> to 2^31") breaks rhashtable users that do not set max_size.  This
> is because when max_size is zero max_elems is also incorrectly set
> to zero instead of 2^31.
> 
> This patch fixes it by only lowering max_elems when max_size is not
> zero.
> 
> Fixes: 6d684e54690c ("rhashtable: Cap total number of entries to 2^31")
> Reported-by: Florian Fainelli <f.fainelli@...il.com>
> Reported-by: kernel test robot <fengguang.wu@...el.com>
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Applied, thanks.