netdev - Re: [PATCH net-next] geneve: fix incorrect setting of UDP checksum flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOrHB_DdSPYRBqc7cAszgfNf6Tp1=ZzhhxTOjkFeBKAsk2arPQ@mail.gmail.com>
Date:   Fri, 28 Apr 2017 11:58:06 -0700
From:   Pravin Shelar <pshelar@....org>
To:     Girish Moodalbail <girish.moodalbail@...cle.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] geneve: fix incorrect setting of UDP checksum flag

On Thu, Apr 27, 2017 at 2:11 PM, Girish Moodalbail
<girish.moodalbail@...cle.com> wrote:
> Creating a geneve link with 'udpcsum' set results in a creation of link
> for which UDP checksum will NOT be computed on outbound packets, as can
> be seen below.
>
> 11: gen0: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN
>     link/ether c2:85:27:b6:b4:15 brd ff:ff:ff:ff:ff:ff promiscuity 0
>     geneve id 200 remote 192.168.13.1 dstport 6081 noudpcsum
>
> Similarly, creating a link with 'noudpcsum' set results in a creation
> of link for which UDP checksum will be computed on outbound packets.
>
> Fixes: 9b4437a5b870 ("geneve: Unify LWT and netdev handling.")
> Signed-off-by: Girish Moodalbail <girish.moodalbail@...cle.com>

LGTM.
Acked-by: Pravin B Shelar <pshelar@....org>