netdev - Re: [PATCH net] net: adjust skb->truesize in ___pskb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170428.160737.2032130324003409164.davem@davemloft.net>
Date:   Fri, 28 Apr 2017 16:07:37 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, andreyknvl@...gle.com, willemb@...gle.com
Subject: Re: [PATCH net] net: adjust skb->truesize in ___pskb_trim()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 26 Apr 2017 09:07:46 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Andrey found a way to trigger the WARN_ON_ONCE(delta < len) in
> skb_try_coalesce() using syzkaller and a filter attached to a TCP
> socket.
> 
> As we did recently in commit 158f323b9868 ("net: adjust skb->truesize in
> pskb_expand_head()") we can adjust skb->truesize from ___pskb_trim(),
> via a call to skb_condense().
> 
> If all frags were freed, then skb->truesize can be recomputed.
> 
> This call can be done if skb is not yet owned, or destructor is
> sock_edemux().
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Andrey Konovalov <andreyknvl@...gle.com>

Also applied, thanks Eric.