netdev - Re: [PATCH net] net: hns: fix ethtool_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170428.161050.111916772197901326.davem@davemloft.net>
Date:   Fri, 28 Apr 2017 16:10:50 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     lixiaoping3@...wei.com
Cc:     huangdaode@...ilicon.com, lipeng321@...wei.com,
        yisen.zhuang@...wei.com, salil.mehta@...wei.com,
        yankejian@...wei.com, mbrugger@...e.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linuxarm@...wei.com
Subject: Re: [PATCH net] net: hns: fix ethtool_get_strings overflow in hns
 driver

From: Timmy Li <lixiaoping3@...wei.com>
Date: Thu, 27 Apr 2017 22:18:16 +0800

> @@ -672,7 +672,7 @@ static void hns_gmac_get_strings(u32 stringset, u8 *data)
>  
>  static int hns_gmac_get_sset_count(int stringset)
>  {
> -	if (stringset == ETH_SS_STATS)
> +	if ((stringset == ETH_SS_STATS) || (stringset == ETH_SS_PRIV_FLAGS))

Excessive parenthesis, please fix this in your entire patch.

Thank you.