lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <1493437835-27097-1-git-send-email-gfree.wind@foxmail.com> Date: Sat, 29 Apr 2017 11:50:35 +0800 From: gfree.wind@...mail.com To: davem@...emloft.net, jiri@...nulli.us, netdev@...r.kernel.org Cc: Gao Feng <gfree.wind@...mail.com> Subject: [PATCH net v3] driver: team: Fix one possbile memleak when fail to register_netdevice From: Gao Feng <gfree.wind@...mail.com> The team driver allocates some resources in its ndo_init func, and free some of them in its destructor func. Then there is one memleak that some errors happen after register_netdevice invokes the ndo_init callback. Because only the ndo_uninit callback is invoked in the error handler of register_netdevice, but destructor not. Now create one new func team_destructor_free to free the mem in the destructor, and ndo_uninit func also invokes it when fail to register the team device. It's not only free all resources, but also follow the original desgin that the resources are freed in the destructor normally after register the device successfully. Signed-off-by: Gao Feng <gfree.wind@...mail.com> --- v3: Split one patch to multiple commits, per David Ahern v2: Move the free in ndo_uninit when fail to register, per Herbert Xu v1: initial version drivers/net/team/team.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index 1b52520..575eb00 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team/team.c @@ -1625,6 +1625,13 @@ static int team_init(struct net_device *dev) return err; } +static void team_destructor_free(struct net_device *dev) +{ + struct team *team = netdev_priv(dev); + + free_percpu(team->pcpu_stats); +} + static void team_uninit(struct net_device *dev) { struct team *team = netdev_priv(dev); @@ -1641,13 +1648,16 @@ static void team_uninit(struct net_device *dev) team_notify_peers_fini(team); team_queue_override_fini(team); mutex_unlock(&team->lock); + + /* dev is not registered, perform the free instead of destructor */ + if (dev->reg_state == NETREG_UNINITIALIZED) + team_destructor_free(dev); + } static void team_destructor(struct net_device *dev) { - struct team *team = netdev_priv(dev); - - free_percpu(team->pcpu_stats); + team_destructor_free(dev); free_netdev(dev); } -- 2.7.4
Powered by blists - more mailing lists