netdev - Re: [PATCH net-next 11/11] ibmvnic: Move queue restart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201704300150.Cq5ZntjP%fengguang.wu@intel.com>
Date:   Sun, 30 Apr 2017 01:18:03 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Nathan Fontenot <nfont@...ux.vnet.ibm.com>
Cc:     kbuild-all@...org, netdev@...r.kernel.org,
        brking@...ux.vnet.ibm.com, jallen@...ux.vnet.ibm.com,
        muvic@...ux.vnet.ibm.com, tlfalcon@...ux.vnet.ibm.com
Subject: Re: [PATCH net-next 11/11] ibmvnic: Move queue restart

Hi Nathan,

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Nathan-Fontenot/ibmvnic-Updated-reset-handler-and-code-fixes/20170430-004245
config: powerpc-allmodconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=powerpc 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   In file included from include/linux/if_ether.h:23:0,
                    from include/uapi/linux/ethtool.h:18,
                    from include/linux/ethtool.h:17,
                    from include/linux/netdevice.h:42,
                    from drivers/net//ethernet/ibm/ibmvnic.c:54:
   drivers/net//ethernet/ibm/ibmvnic.c: In function 'ibmvnic_interrupt_tx':
>> include/linux/skbuff.h:3689:12: warning: 'skb' may be used uninitialized in this function [-Wmaybe-uninitialized]
     return skb->queue_mapping;
            ~~~^~~~~~~~~~~~~~~
   drivers/net//ethernet/ibm/ibmvnic.c:1779:18: note: 'skb' was declared here
     struct sk_buff *skb;
                     ^~~
--
   In file included from include/linux/if_ether.h:23:0,
                    from include/uapi/linux/ethtool.h:18,
                    from include/linux/ethtool.h:17,
                    from include/linux/netdevice.h:42,
                    from drivers/net/ethernet/ibm/ibmvnic.c:54:
   drivers/net/ethernet/ibm/ibmvnic.c: In function 'ibmvnic_interrupt_tx':
>> include/linux/skbuff.h:3689:12: warning: 'skb' may be used uninitialized in this function [-Wmaybe-uninitialized]
     return skb->queue_mapping;
            ~~~^~~~~~~~~~~~~~~
   drivers/net/ethernet/ibm/ibmvnic.c:1779:18: note: 'skb' was declared here
     struct sk_buff *skb;
                     ^~~

vim +/skb +3689 include/linux/skbuff.h

574f7194 Eric W. Biederman     2014-04-01  3673  	return !skb->destructor &&
574f7194 Eric W. Biederman     2014-04-01  3674  #if IS_ENABLED(CONFIG_XFRM)
574f7194 Eric W. Biederman     2014-04-01  3675  		!skb->sp &&
574f7194 Eric W. Biederman     2014-04-01  3676  #endif
cb9c6836 Florian Westphal      2017-01-23  3677  		!skb_nfct(skb) &&
574f7194 Eric W. Biederman     2014-04-01  3678  		!skb->_skb_refdst &&
574f7194 Eric W. Biederman     2014-04-01  3679  		!skb_has_frag_list(skb);
574f7194 Eric W. Biederman     2014-04-01  3680  }
574f7194 Eric W. Biederman     2014-04-01  3681  
f25f4e44 Peter P Waskiewicz Jr 2007-07-06  3682  static inline void skb_set_queue_mapping(struct sk_buff *skb, u16 queue_mapping)
f25f4e44 Peter P Waskiewicz Jr 2007-07-06  3683  {
f25f4e44 Peter P Waskiewicz Jr 2007-07-06  3684  	skb->queue_mapping = queue_mapping;
f25f4e44 Peter P Waskiewicz Jr 2007-07-06  3685  }
f25f4e44 Peter P Waskiewicz Jr 2007-07-06  3686  
9247744e Stephen Hemminger     2009-03-21  3687  static inline u16 skb_get_queue_mapping(const struct sk_buff *skb)
4e3ab47a Pavel Emelyanov       2007-10-21  3688  {
4e3ab47a Pavel Emelyanov       2007-10-21 @3689  	return skb->queue_mapping;
4e3ab47a Pavel Emelyanov       2007-10-21  3690  }
4e3ab47a Pavel Emelyanov       2007-10-21  3691  
f25f4e44 Peter P Waskiewicz Jr 2007-07-06  3692  static inline void skb_copy_queue_mapping(struct sk_buff *to, const struct sk_buff *from)
f25f4e44 Peter P Waskiewicz Jr 2007-07-06  3693  {
f25f4e44 Peter P Waskiewicz Jr 2007-07-06  3694  	to->queue_mapping = from->queue_mapping;
f25f4e44 Peter P Waskiewicz Jr 2007-07-06  3695  }
f25f4e44 Peter P Waskiewicz Jr 2007-07-06  3696  
d5a9e24a David S. Miller       2009-01-27  3697  static inline void skb_record_rx_queue(struct sk_buff *skb, u16 rx_queue)

:::::: The code at line 3689 was first introduced by commit
:::::: 4e3ab47a547616e583c7a5458beced6aa34c8ef3 [NET]: Make and use skb_get_queue_mapping

:::::: TO: Pavel Emelyanov <xemul@...nvz.org>
:::::: CC: David S. Miller <davem@...set.davemloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (52793 bytes)