lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 30 Apr 2017 07:54:32 +0000 From: "Mintz, Yuval" <Yuval.Mintz@...ium.com> To: Dan Carpenter <dan.carpenter@...cle.com> CC: "Elior, Ariel" <Ariel.Elior@...ium.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org> Subject: RE: [PATCH net] qed: Unlock on error in qed_vf_pf_acquire() > My static checker complains that we're holding a mutex on this error path. > Let's goto exit instead of returning directly. > > Fixes: b0bccb69eba3 ("qed: Change locking scheme for VF channel") > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com> > --- > Yuval, could you review this one a bit carefully and also check that my Fixes > tag is correct because I'm not certain. Yes it seems like the right one. Thanks! Acked-by: Yuval Mintz <Yuval.Mintz@...ium.com>
Powered by blists - more mailing lists