netdev - Re: [PATCH/RFC net-next 0/4] net/sched: cls_flower: avoid false matching of truncated packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <80417d97-4c47-c77b-9c8c-9e2487250a76@mojatatu.com>
Date:   Sun, 30 Apr 2017 10:45:34 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Simon Horman <simon.horman@...ronome.com>
Cc:     Jiri Pirko <jiri@...lanox.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Dinan Gunawardena <dinan.gunawardena@...ronome.com>,
        netdev@...r.kernel.org, oss-drivers@...ronome.com
Subject: Re: [PATCH/RFC net-next 0/4] net/sched: cls_flower: avoid false
 matching of truncated packets

On 17-04-30 09:51 AM, Jamal Hadi Salim wrote:

[..]

>> 1. As things stand, without this patch-set, flower does not differentiate
>>    between a packet truncated at the end of the IP header and a packet
>> with
>>    zero ports. Likewise for icmp type and code of zero.
>>
>>    The first three patches of this series address that so that a match
>> for
>>    port == zero only matches if ports are present in the packet. Again,
>>    likewise for ICMP.
>>
>>    This is a bug-fix to my way of thinking.
>>
>
> Agreed to bug fix. I would have said there is never a legit packet with
> TCP/UDP

Meant:
"never a legit packet with TCP/UDP port 0 on the wire".

cheers,
jamal