netdev - Re: [PATCH net-next 00/18] net: dsa: mv88e6xxx: 802.1s and 88E6390 VTU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170501.122618.1787371573631638101.davem@davemloft.net>
Date:   Mon, 01 May 2017 12:26:18 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     vivien.didelot@...oirfairelinux.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...oirfairelinux.com, f.fainelli@...il.com, andrew@...n.ch
Subject: Re: [PATCH net-next 00/18] net: dsa: mv88e6xxx: 802.1s and 88E6390
 VTU

From: Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Date: Mon, 01 May 2017 12:21:31 -0400

> Hi David,
> 
> David Miller <davem@...emloft.net> writes:
> 
>> From: Vivien Didelot <vivien.didelot@...oirfairelinux.com>
>> Date: Mon, 01 May 2017 11:51:05 -0400
>>
>>> Hi David,
>>> 
>>> Vivien Didelot <vivien.didelot@...oirfairelinux.com> writes:
>>> 
>>>> Vivien Didelot (18):
>>>>   net: dsa: mv88e6xxx: add max VID to info
>>>>   net: dsa: mv88e6xxx: split VTU entry data member
>>>>   net: dsa: mv88e6xxx: move VTU Operation accessors
>>>>   net: dsa: mv88e6xxx: move VTU flush
>>>>   net: dsa: mv88e6xxx: move VTU FID accessors
>>>>   net: dsa: mv88e6xxx: move VTU SID accessors
>>>>   net: dsa: mv88e6xxx: move VTU VID accessors
>>>>   net: dsa: mv88e6xxx: move generic VTU GetNext
>>>>   net: dsa: mv88e6xxx: move VTU Data accessors
>>>>   net: dsa: mv88e6xxx: move STU GetNext operation
>>>>   net: dsa: mv88e6xxx: get STU entry on VTU GetNext
>>>>   net: dsa: mv88e6xxx: load STU entry with VTU entry
>>>>   net: dsa: mv88e6xxx: add VTU GetNext operation
>>>>   net: dsa: mv88e6xxx: add VTU Load/Purge operation
>>>>   net: dsa: mv88e6xxx: make VTU helpers static
>>>>   net: dsa: mv88e6xxx: simplify VTU entry getter
>>>>   net: dsa: mv88e6xxx: support the VTU Page bit
>>>>   net: dsa: mv88e6xxx: add VTU support for 88E6390
>>>>
>>>>  drivers/net/dsa/mv88e6xxx/Makefile      |   1 +
>>>>  drivers/net/dsa/mv88e6xxx/chip.c        | 568 +++++++++-----------------------
>>>>  drivers/net/dsa/mv88e6xxx/global1.h     |  14 +
>>>>  drivers/net/dsa/mv88e6xxx/global1_vtu.c | 505 ++++++++++++++++++++++++++++
>>>>  drivers/net/dsa/mv88e6xxx/mv88e6xxx.h   |  31 +-
>>>>  5 files changed, 684 insertions(+), 435 deletions(-)
>>>>  create mode 100644 drivers/net/dsa/mv88e6xxx/global1_vtu.c
>>> 
>>> I don't see the patchset in net-next. Can you pick it?
>>
>> This had feedback which you must address, therefore the state in
>> patchwork is "changes requested" which you could have checked before
>> asking me this.
>>
>> If the patch set is fine and you got ACKs for all of your patches
>> then please resubmit.
>>
>> Otherwise, make the changes you were asked to make or explain to
>> the person who asked for them why they are not appropriate.
> 
> We did discuss the patchset and everything is good as is. Can someone
> change the state in patchwork afterwards? It feels weird to resend the
> patch with no changes.

Once I set the state to "changes requested", that's basically permanent.

Please simply resubmit your patch series, ACKs added if necessary.

Thanks.