lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 30 Apr 2017 23:04:48 -0400 (EDT) From: David Miller <davem@...emloft.net> To: idosch@...lanox.com Cc: netdev@...r.kernel.org, jiri@...lanox.com, mlxsw@...lanox.com Subject: Re: [PATCH net-next] mlxsw: spectrum_router: Simplify VRF enslavement From: <idosch@...lanox.com> Date: Sun, 30 Apr 2017 19:47:14 +0300 > From: Ido Schimmel <idosch@...lanox.com> > > When a netdev is enslaved to a VRF master, its router interface (RIF) > needs to be destroyed (if exists) and a new one created using the > corresponding virtual router (VR). > > From the driver's perspective, the above is equivalent to an inetaddr > event sent for this netdev. Therefore, when a port netdev (or its > uppers) are enslaved to a VRF master, call the same function that > would've been called had a NETDEV_UP was sent for this netdev in the > inetaddr notification chain. > > This patch also fixes a bug when a LAG netdev with an existing RIF is > enslaved to a VRF. Before this patch, each LAG port would drop the > reference on the RIF, but would re-join the same one (in the wrong VR) > soon after. With this patch, the corresponding RIF is first destroyed > and a new one is created using the correct VR. > > Fixes: 7179eb5acd59 ("mlxsw: spectrum_router: Add support for VRFs") > Signed-off-by: Ido Schimmel <idosch@...lanox.com> > Reviewed-by: Jiri Pirko <jiri@...lanox.com> Applied, thanks.
Powered by blists - more mailing lists