netdev - Re: [PATCH net] tcp: fix access to sk->sk_state in tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170430.222511.1580121304843279513.davem@davemloft.net>
Date:   Sun, 30 Apr 2017 22:25:11 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     dcaratti@...hat.com
Cc:     kuznet@....inr.ac.ru, jmorris@...ei.org, yoshfuji@...ux-ipv6.org,
        kaber@...sh.net, weiwan@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] tcp: fix access to sk->sk_state in tcp_poll()

From: Davide Caratti <dcaratti@...hat.com>
Date: Wed, 26 Apr 2017 19:07:35 +0200

> avoid direct access to sk->sk_state when tcp_poll() is called on a socket
> using active TCP fastopen with deferred connect. Use local variable
> 'state', which stores the result of sk_state_load(), like it was done in
> commit 00fd38d938db ("tcp: ensure proper barriers in lockless contexts").
> 
> Fixes: 19f6d3f3c842 ("net/tcp-fastopen: Add new API support")
> Signed-off-by: Davide Caratti <dcaratti@...hat.com>

Applied.