netdev - Re: [PATCH net-next 1/4] netlink: add NULL-friendly helper for setting extended ACK message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <590711E1.7060400@iogearbox.net>
Date:   Mon, 01 May 2017 12:45:53 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        netdev@...r.kernel.org
CC:     davem@...emloft.net, johannes@...solutions.net,
        dsa@...ulusnetworks.com, alexei.starovoitov@...il.com,
        bblanco@...il.com, john.fastabend@...il.com, kubakici@...pl,
        oss-drivers@...ronome.com, brouer@...hat.com, jhs@...atatu.com
Subject: Re: [PATCH net-next 1/4] netlink: add NULL-friendly helper for setting
 extended ACK message

On 05/01/2017 06:46 AM, Jakub Kicinski wrote:
> As we propagate extended ack reporting throughout various paths in
> the kernel it may be that the same function is called with the
> extended ack parameter passed as NULL.  One place where that happens
> is in drivers which have a centralized reconfiguration function
> called both from ndos and from ethtool_ops.  Add a new helper for
> setting the error message in such conditions.
>
> Existing helper is left as is to encourage propagating the ext act
> fully wherever possible.  It also makes it clear in the code which
> messages may be lost due to ext ack being NULL.
>
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Acked-by: Daniel Borkmann <daniel@...earbox.net>