netdev - Re: [RFC PATCH v2 07/17] net: sched: drop qdisc_reset from dev_graft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170502220053.0b460e38@redhat.com>
Date:   Tue, 2 May 2017 22:00:53 +0200
From:   Jesper Dangaard Brouer <brouer@...hat.com>
To:     John Fastabend <john.fastabend@...il.com>
Cc:     brouer@...hat.com, eric.dumazet@...il.com, netdev@...r.kernel.org
Subject: Re: [RFC PATCH v2 07/17] net: sched: drop qdisc_reset from
 dev_graft_qdisc

On Tue, 02 May 2017 08:38:19 -0700
John Fastabend <john.fastabend@...il.com> wrote:

> @@ -991,20 +996,25 @@ void dev_deactivate_many(struct list_head *head)
>  					     &noop_qdisc);
>  
>  		dev_watchdog_down(dev);
> -		sync_needed |= !dev->dismantle;
>  	}
>  
>  	/* Wait for outstanding qdisc-less dev_queue_xmit calls.
>  	 * This is avoided if all devices are in dismantle phase :
>  	 * Caller will call synchronize_net() for us
>  	 */

Is the comment still correct after this change?

> -	if (sync_needed)
> -		synchronize_net();
> +	synchronize_net();

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer