netdev - Re: [PATCH net] tg3: don't clear stats while tg3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 03 May 2017 09:54:05 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     yuehaibing@...wei.com
Cc:     netdev@...r.kernel.org, weiyongjun1@...wei.com
Subject: Re: [PATCH net] tg3: don't clear stats while tg3_close

From: YueHaibing <yuehaibing@...wei.com>
Date: Wed, 3 May 2017 15:51:32 +0800

> Now tg3 NIC's stats will be cleared after ifdown/ifup. bond_get_stats traverse
> its salves to get statistics,cumulative the increment.If a tg3 NIC is added to
> bonding as a slave,ifdown/ifup will cause bonding's stats become tremendous value
> (ex.1638.3 PiB) because of negative increment.
> 
> Fixes: 92feeabf3f67 ("tg3: Save stats across chip resets")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Indeed, no driver should clear statistics over open/close.

Applied, thanks.