| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20170503230117.20070-12-sthemmin@microsoft.com> Date: Wed, 3 May 2017 16:01:13 -0700 From: Stephen Hemminger <stephen@...workplumber.org> To: davem@...emloft.net Cc: netdev@...r.kernel.org, Stephen Hemminger <sthemmin@...rosoft.com> Subject: [PATCH net-next 11/15] netvsc: reduce unnecessary memset Only part of the headroom maybe used on typical packet. Avoid doing memset of whole area. Signed-off-by: Stephen Hemminger <sthemmin@...rosoft.com> --- drivers/net/hyperv/netvsc_drv.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index ef3a3a46790f..d9a690ad7cd5 100644 --- a/drivers/net/hyperv/netvsc_drv.c +++ b/drivers/net/hyperv/netvsc_drv.c @@ -195,6 +195,7 @@ static void *init_ppi_data(struct rndis_message *msg, u32 ppi_size, ppi->size = ppi_size; ppi->type = pkt_type; ppi->ppi_offset = sizeof(struct rndis_per_packet_info); + memset(ppi + 1, 0, ppi_size - sizeof(struct rndis_per_packet_info)); rndis_pkt->per_pkt_info_len += ppi_size; @@ -461,12 +462,12 @@ static int netvsc_start_xmit(struct sk_buff *skb, struct net_device *net) rndis_msg = (struct rndis_message *)skb->head; - memset(rndis_msg, 0, RNDIS_AND_PPI_SIZE); - /* Add the rndis header */ rndis_msg->ndis_msg_type = RNDIS_MSG_PACKET; rndis_msg->msg_len = packet->total_data_buflen; + rndis_pkt = &rndis_msg->msg.pkt; + memset(rndis_pkt, 0, sizeof(*rndis_pkt)); rndis_pkt->data_offset = sizeof(struct rndis_packet); rndis_pkt->data_len = packet->total_data_buflen; rndis_pkt->per_pkt_info_offset = sizeof(struct rndis_packet); -- 2.11.0
Powered by blists - more mailing lists