netdev - RE: [PATCH] Fix for new version of realtek r8153

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0835B3720019904CB8F7AA43166CEEB201A4BB27@RTITMBSV06.realtek.com.tw>
Date:   Wed, 3 May 2017 09:18:38 +0000
From:   Hayes Wang <hayeswang@...ltek.com>
To:     jake Briggs <nexussix@...il.com>,
        "mario_limonciello@...l.com" <mario_limonciello@...l.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     jake <jake@...idtech.co.nz>, nic_swsd <nic_swsd@...ltek.com>
Subject: RE: [PATCH] Fix for new version of realtek r8153

jake Briggs [mailto:nexussix@...il.com]
> Sent: Wednesday, May 03, 2017 7:21 AM
[...]
> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
> index 07f788c49d57..2a55459fdfac 100644
> --- a/drivers/net/usb/r8152.c
> +++ b/drivers/net/usb/r8152.c
> @@ -4277,6 +4277,7 @@ static void r8152b_get_version(struct r8152 *tp)
>  		tp->mii.supports_gmii = 1;
>  		break;
>  	case 0x5c30:
> +	case 0x6010:

The two chips are different. I don't think it is a good idea.
Maybe you could use the driver from the Realtek website first.

>  		tp->version = RTL_VER_06;
>  		tp->mii.supports_gmii = 1;
>  		break;