netdev - Re: [PATCH] test_bpf: Use ULL suffix for 64-bit constants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5909C061.7090409@iogearbox.net>
Date:   Wed, 03 May 2017 13:34:57 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        "David S . Miller" <davem@...emloft.net>,
        Alexei Starovoitov <ast@...nel.org>
CC:     netdev@...r.kernel.org, --cc@...san.of.borg,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] test_bpf: Use ULL suffix for 64-bit constants

On 05/03/2017 01:31 PM, Geert Uytterhoeven wrote:
> On 32-bit:
>
>      lib/test_bpf.c:4772: warning: integer constant is too large for ‘unsigned long’ type
>      lib/test_bpf.c:4772: warning: integer constant is too large for ‘unsigned long’ type
>      lib/test_bpf.c:4773: warning: integer constant is too large for ‘unsigned long’ type
>      lib/test_bpf.c:4773: warning: integer constant is too large for ‘unsigned long’ type
>      lib/test_bpf.c:4787: warning: integer constant is too large for ‘unsigned long’ type
>      lib/test_bpf.c:4787: warning: integer constant is too large for ‘unsigned long’ type
>      lib/test_bpf.c:4801: warning: integer constant is too large for ‘unsigned long’ type
>      lib/test_bpf.c:4801: warning: integer constant is too large for ‘unsigned long’ type
>      lib/test_bpf.c:4802: warning: integer constant is too large for ‘unsigned long’ type
>      lib/test_bpf.c:4802: warning: integer constant is too large for ‘unsigned long’ type
>
> On 32-bit systems, "long" is only 32-bit.
> Replace the "UL" suffix by "ULL" to fix this.
>
> Fixes: 85f68fe898320575 ("bpf, arm64: implement jiting of BPF_XADD")
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Yep, of course, not sure how I missed it! :/ Thanks!

Acked-by: Daniel Borkmann <daniel@...earbox.net>