netdev - Re: [PATCH v2 2/2] can: m_can: add deep Suspend/Resume support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6a6f521c-c551-703b-d5e2-d47999ae454b@free-electrons.com>
Date:   Wed, 3 May 2017 14:40:12 +0200
From:   Quentin Schulz <quentin.schulz@...e-electrons.com>
To:     wg@...ndegger.com, mkl@...gutronix.de, mario.huettel@....net,
        socketcan@...tkopp.net
Cc:     linux-can@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, alexandre.belloni@...e-electrons.com,
        thomas.petazzoni@...e-electrons.com
Subject: Re: [PATCH v2 2/2] can: m_can: add deep Suspend/Resume support

Hum, forgot the changelog.

On 03/05/2017 14:37, Quentin Schulz wrote:
> This adds Power Management deep Suspend/Resume support for Bosch M_CAN
> chip.
> 
> When the system resumes from deep sleep, the chip needs to be fully
> reinitialized (RAM, chip, clocks, irq, candev, ...) to be functional.
> 
> Signed-off-by: Quentin Schulz <quentin.schulz@...e-electrons.com>
> ---

v2:
 - fix erroneous commit log,

>  drivers/net/can/m_can/m_can.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
> index 3f0445440146..9e0143b528f1 100644
> --- a/drivers/net/can/m_can/m_can.c
> +++ b/drivers/net/can/m_can/m_can.c
> @@ -1670,12 +1670,10 @@ static __maybe_unused int m_can_suspend(struct device *dev)
>  	struct m_can_priv *priv = netdev_priv(ndev);
>  
>  	if (netif_running(ndev)) {
> -		netif_stop_queue(ndev);
>  		netif_device_detach(ndev);
> +		m_can_close(ndev);
>  	}
>  
> -	/* TODO: enter low power */
> -
>  	priv->can.state = CAN_STATE_SLEEPING;
>  
>  	return 0;
> @@ -1686,13 +1684,13 @@ static __maybe_unused int m_can_resume(struct device *dev)
>  	struct net_device *ndev = dev_get_drvdata(dev);
>  	struct m_can_priv *priv = netdev_priv(ndev);
>  
> -	/* TODO: exit low power */
> +	m_can_init_ram(priv);
>  
>  	priv->can.state = CAN_STATE_ERROR_ACTIVE;
>  
>  	if (netif_running(ndev)) {
> +		m_can_open(ndev);
>  		netif_device_attach(ndev);
> -		netif_start_queue(ndev);
>  	}
>  
>  	return 0;
> 

-- 
Quentin Schulz, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com