netdev - Re: [PATCH net] rtnetlink: NUL-terminate IFLA_PHYS_PORT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170504.112442.1701097085035128140.davem@davemloft.net>
Date:   Thu, 04 May 2017 11:24:42 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     mschmidt@...hat.com
Cc:     netdev@...r.kernel.org, thaller@...hat.com, dsahern@...il.com
Subject: Re: [PATCH net] rtnetlink: NUL-terminate IFLA_PHYS_PORT_NAME string

From: Michal Schmidt <mschmidt@...hat.com>
Date: Thu,  4 May 2017 16:48:58 +0200

> IFLA_PHYS_PORT_NAME is a string attribute, so terminate it with \0.
> Otherwise libnl3 fails to validate netlink messages with this attribute.
> "ip -detail a" assumes too that the attribute is NUL-terminated when
> printing it. It often was, due to padding.
> 
> I noticed this as libvirtd failing to start on a system with sfc driver
> after upgrading it to Linux 4.11, i.e. when sfc added support for
> phys_port_name.
> 
> Signed-off-by: Michal Schmidt <mschmidt@...hat.com>

Good catch, applied and queued up for -stable, thanks.