netdev - Re: [Patch net] ipv6: initialize route null entry in addrconf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170504.125144.78973292337920988.davem@davemloft.net>
Date:   Thu, 04 May 2017 12:51:44 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     andreyknvl@...gle.com
Cc:     xiyou.wangcong@...il.com, netdev@...r.kernel.org, dsahern@...il.com
Subject: Re: [Patch net] ipv6: initialize route null entry in
 addrconf_init()

From: Andrey Konovalov <andreyknvl@...gle.com>
Date: Thu, 4 May 2017 14:28:37 +0200

> On Thu, May 4, 2017 at 7:07 AM, Cong Wang <xiyou.wangcong@...il.com> wrote:
>> Andrey reported a crash on init_net.ipv6.ip6_null_entry->rt6i_idev
>> since it is always NULL.
>>
>> This is clearly wrong, we have code to initialize it to loopback_dev,
>> unfortunately the order is still not correct.
>>
>> loopback_dev is registered very early during boot, we lose a chance
>> to re-initialize it in notifier. addrconf_init() is called after
>> ip6_route_init(), which means we have no chance to correct it.
>>
>> Fix it by moving this initialization explicitly after
>> ipv6_add_dev(init_net.loopback_dev) in addrconf_init().
>>
>> Reported-by: Andrey Konovalov <andreyknvl@...gle.com>
>> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>
> 
> Hi Cong,
> 
> This fixes the bug triggered by my reproducer.
> 
> Thanks!
> 
> Tested-by: Andrey Konovalov <andreyknvl@...gle.com>

Applied and queued up for -stable, thanks.