netdev - Re: [PATCH] aquantia: Fix "ethtool -S" crash when adapter down.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 4 May 2017 21:08:06 +0200
From:   Lino Sanfilippo <LinoSanfilippo@....de>
To:     Pavel Belous <pavel.belous@...antia.com>,
        David Arcari <darcari@...hat.com>,
        David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] aquantia: Fix "ethtool -S" crash when adapter down.

On 04.05.2017 20:37, Pavel Belous wrote:

> 
> Yes, even adapter is in the down state user can still see statistics from the HW.
> For example (adapter is down):
> 
> $ ethtool -S enp2s0
> NIC statistics:
>      InPackets: 3237727
>      InUCast: 3237214
>      InMCast: 391
>      InBCast: 122
>      InErrors: 0
>      OutPackets: 14157898
>      OutUCast: 14157089
>      OutMCast: 304
>      OutBCast: 505
>      InUCastOctects: 226714406
>      OutUCastOctects: 10463156
>      InMCastOctects: 58046
>      OutMCastOctects: 44817
>      InBCastOctects: 12857
>      OutBCastOctects: 41626
>      InOctects: 226785309
>      OutOctects: 10549599
>      InPacketsDma: 0
>      OutPacketsDma: 16
>      InOctetsDma: 0
>      OutOctetsDma: 2396
>      InDroppedDma: 0
>      Queue[0] InPackets: 0
>      Queue[0] OutPackets: 0
>      Queue[0] InJumboPackets: 0
>      Queue[0] InLroPackets: 0
>      Queue[0] InErrors: 0
>      Queue[1] InPackets: 0
>      Queue[1] OutPackets: 0
>      Queue[1] InJumboPackets: 0
>      Queue[1] InLroPackets: 0
>      Queue[1] InErrors: 0
>      Queue[2] InPackets: 0
>      Queue[2] OutPackets: 0
>      Queue[2] InJumboPackets: 0
>      Queue[2] InLroPackets: 0
>      Queue[2] InErrors: 0
>      Queue[3] InPackets: 0
>      Queue[3] OutPackets: 0
>      Queue[3] InJumboPackets: 0
>      Queue[3] InLroPackets: 0
>      Queue[3] InErrors: 0
> 
> Lino, David what do you think?
> If you agree I can re-submit the patch (with fixed braces).
> 

Well my objection was related to how the bug is fixed. If in the end we have a solution
as suggested by David it would be even better, of course. I dont think that this is too
hard to realize since it is only the queues stats that are missing. But if you prefer to 
solve it in two steps, sure, no objections from my side :)

Regards,
Lino