lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 5 May 2017 09:30:35 +0200
From:   Christoph Hellwig <>
To:     Amir Goldstein <>
Cc:     Dan Williams <>,
        Andy Shevchenko <>,
        Linux ACPI <>,,,,,,,
        Netdev <>,,
        USB list <>,,
        "" <>,
        "Rafael J . Wysocki" <>,
        Mika Westerberg <>,
        Borislav Petkov <>,
        Jarkko Sakkinen <>,
        Jani Nikula <>,
        Ben Skeggs <>,
        Benjamin Tissoires <>,
        Joerg Roedel <>,
        Adrian Hunter <>,
        Yisen Zhuang <>,
        Bjorn Helgaas <>,
        Zhang Rui <>,
        Felipe Balbi <>,
        Mathias Nyman <>,
        Heikki Krogerus <>,
        Liam Girdwood <>,
        Mark Brown <>, Christoph Hellwig <>
Subject: Re: [PATCH v1] ACPI: Switch to use generic UUID API

On Fri, May 05, 2017 at 10:06:06AM +0300, Amir Goldstein wrote:
> I much rather that you sort out uuid helpers in a way that will
> satisfy the filesystem
> needs (just provide the helpers don't need to convert filesystems code).


> IMO, you should acknowledge that the common use case for filesystems is
> to handle an opaque char[16] which most likely holds a uuid_be and you
> should provide 'neutral' helpers to satisfy this use case.
> The simplest would be to typedef uuid_t to struct uuid_be and to name 'neutral'
> helpers' uuid_cmp/uuid_copy(uuid_t *, uuid_t *), similar to my proposal.

It's not jut neutral, it's the right thing to to.  The Apollo / DCE
uuids (later also specified in RFC 4122) are big endian, so we should
use the name there.

> Christoph also suggested a similar treatment to typedef guid_t to
> struct uuid_le.

Exactly.  The whole idea of "little endian UUIDs" comes from the
Wintel world, and if you look at the relevant specs they are almost
exclusively referred to as GUIDs.

The magic XFS and AFS types for specific interpretations of one of
the RFC4122 formats don't really help, but I'll just send a patch
to kill them off for XFS ASAP to at least get that out, and we
probably should revert at least

"afs: Move UUID struct to linux/uuid.h"

That moved the AFS mess to common code as a start, and then
also clean up the way we generate random UUIDs, where we currently
have le helper, a be helper and then also generate_random_uuid
just to confuse the heck out of people.  With no description of
either of them.

Powered by blists - more mailing lists