netdev - Re: [PATCH v1] ACPI: Switch to use generic UUID API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170505095739.GB6762@lst.de>
Date:   Fri, 5 May 2017 11:57:39 +0200
From:   Christoph Hellwig <hch@....de>
To:     Amir Goldstein <amir73il@...il.com>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Linux ACPI <linux-acpi@...r.kernel.org>,
        tpmdd-devel@...ts.sourceforge.net, intel-gfx@...ts.freedesktop.org,
        nouveau@...ts.freedesktop.org, linux-input@...r.kernel.org,
        iommu@...ts.linux-foundation.org, linux-mmc@...r.kernel.org,
        Netdev <netdev@...r.kernel.org>, linux-pci@...r.kernel.org,
        USB list <linux-usb@...r.kernel.org>,
        alsa-devel@...a-project.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Rafael J . Wysocki" <rjw@...ysocki.net>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Borislav Petkov <bp@...e.de>,
        Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
        Jani Nikula <jani.nikula@...ux.intel.com>,
        Ben Skeggs <bskeggs@...hat.com>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Joerg Roedel <joro@...tes.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Yisen Zhuang <yisen.zhuang@...wei.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Zhang Rui <rui.zhang@...el.com>,
        Felipe Balbi <balbi@...nel.org>,
        Mathias Nyman <mathias.nyman@...el.com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>, Christoph Hellwig <hch@....de>
Subject: Re: [PATCH v1] ACPI: Switch to use generic UUID API

On Fri, May 05, 2017 at 12:50:31PM +0300, Amir Goldstein wrote:
> To complete the picture for folks not cc'ed on my patches,
> xfs use case suggests there is also justification for the additional helpers:
> 
> uuid_is_null() / uuid_equal()
> guid_is_null() / guid_equal()

The is_null is useful and I bet we'll find other instances.  I'm
not sure _equals really adds much value over the existing _cmp
helpers, but on the other hand they are so trivial that we might as
well add them.

The other thing XFS has is uuid_copy.