lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <b5b672573585b51a3acb37231f38db45f5873f60.1493781695.git.geliangtang@gmail.com> Date: Sat, 6 May 2017 23:42:19 +0800 From: Geliang Tang <geliangtang@...il.com> To: Maya Erez <qca_merez@....qualcomm.com>, Kalle Valo <kvalo@...eaurora.org> Cc: Geliang Tang <geliangtang@...il.com>, linux-wireless@...r.kernel.org, wil6210@....qualcomm.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH] wil6210: use memdup_user Use memdup_user() helper instead of open-coding to simplify the code. Signed-off-by: Geliang Tang <geliangtang@...il.com> --- drivers/net/wireless/ath/wil6210/debugfs.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/ath/wil6210/debugfs.c b/drivers/net/wireless/ath/wil6210/debugfs.c index 5648ebb..5b0f9fc 100644 --- a/drivers/net/wireless/ath/wil6210/debugfs.c +++ b/drivers/net/wireless/ath/wil6210/debugfs.c @@ -795,15 +795,11 @@ static ssize_t wil_write_file_txmgmt(struct file *file, const char __user *buf, struct wireless_dev *wdev = wil_to_wdev(wil); struct cfg80211_mgmt_tx_params params; int rc; - void *frame = kmalloc(len, GFP_KERNEL); + void *frame; - if (!frame) - return -ENOMEM; - - if (copy_from_user(frame, buf, len)) { - kfree(frame); - return -EIO; - } + frame = memdup_user(buf, len); + if (IS_ERR(frame)) + return PTR_ERR(frame); params.buf = frame; params.len = len; -- 2.9.3
Powered by blists - more mailing lists