netdev - Re: [PATCH net] ip6_tunnel: remove unreachable ICMP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 08 May 2017 15:59:03 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     liuhangbin@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] ip6_tunnel: remove unreachable ICMP_REDIRECT code

From: Hangbin Liu <liuhangbin@...il.com>
Date: Mon,  8 May 2017 19:11:03 +0800

> After call ip6_tnl_err(), the rel_type will be ether ICMPV6_DEST_UNREACH
> or ICMPV6_PKT_TOOBIG. We will never reach ICMP_REDIRECT. So remove it.
> 
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>

Your patches here, all seemingly due to "visual inspection", are starting
to really, truly, irritate me.

Half of them are unnecessary, some are completely buggy.

I have to review them and audit them very satrictly as a result, and
this takes up an unnecessarily large amount of my time.

Therefore, I'm basically going to stop looking at your changes _unless_
you can show that you specifically tested and exercised all of the code
paths you are changing.

I am sorry to have to do this, but the value to effort ratio of
reviewing and integrating your changes is quite poor.