netdev - Re: [PATCH net v2 1/1] xfrm: Fix NETDEV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170508115008.GC9813@secunet.com>
Date:   Mon, 8 May 2017 13:50:08 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     <ilant@...lanox.com>
CC:     David Miller <davem@...emloft.net>,
        Boris Pismenny <borisp@...lanox.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net v2 1/1] xfrm: Fix NETDEV_DOWN with IPSec offload

On Mon, May 08, 2017 at 10:39:34AM +0300, ilant@...lanox.com wrote:
> From: Ilan Tayari <ilant@...lanox.com>
> 
> Upon NETDEV_DOWN event, all xfrm_state objects which are bound to
> the device are flushed.
> 
> The condition for this is wrong, though, testing dev->hw_features
> instead of dev->features. If a device has non-user-modifiable
> NETIF_F_HW_ESP, then its xfrm_state objects are not flushed,
> causing a crash later on after the device is deleted.
> 
> Check dev->features instead of dev->hw_features.
> 
> Fixes: d77e38e612a0 ("xfrm: Add an IPsec hardware offloading API")
> Signed-off-by: Ilan Tayari <ilant@...lanox.com>

Applied, thanks Ilan!