lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAHp75Vc1YeD9DvwVLh7U1CtDWRGpm-zQSbf4d8C=skLcf_ucBg@mail.gmail.com> Date: Mon, 8 May 2017 14:56:10 +0300 From: Andy Shevchenko <andy.shevchenko@...il.com> To: Joao Pinto <Joao.Pinto@...opsys.com> Cc: Jan Kiszka <jan.kiszka@...mens.com>, "David S. Miller" <davem@...emloft.net>, Giuseppe CAVALLARO <peppe.cavallaro@...com>, Alexandre TORGUE <alexandre.torgue@...com>, netdev <netdev@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v3 net-next 01/11] net: stmmac: prepare dma op mode config for multiple queues On Mon, May 8, 2017 at 2:40 PM, Joao Pinto <Joao.Pinto@...opsys.com> wrote: > Às 12:34 PM de 5/8/2017, Andy Shevchenko escreveu: >> On Mon, May 8, 2017 at 1:42 PM, Joao Pinto <Joao.Pinto@...opsys.com> wrote: >>> Às 11:12 AM de 5/8/2017, Andy Shevchenko escreveu: >>>> On Mon, May 8, 2017 at 12:54 PM, Joao Pinto <Joao.Pinto@...opsys.com> wrote: >>>>> Às 10:36 AM de 5/8/2017, Andy Shevchenko escreveu: >> >> [ 44.374161] stmmac_dvr_probe <<< 0 0 >> > > Ok, so this is the cause of the problem. The driver is geting 0 for real RX and > TX queues. > > Your setup uses standard DT parsing from stmmac_platform or a custom one? > > If you are using stmmac_probe_config_dt(): > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c#n363 > > You will find a function named stmmac_mtl_setup() being called: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c#n492 > > In this function, the number of RX and TX queues is being set to 1 by default. Ah-ha, now I know how it's happened. You forget to update all setup() hooks in PCI bus driver :-) I will prepare a fix. Just tell me should I put Fixes tag or not? And if yes, what commit should I refer to? -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists