lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <8594c152-68a4-c0c7-b4c6-49c753b0c748@gmx.de> Date: Mon, 8 May 2017 19:08:40 +0200 From: Lino Sanfilippo <LinoSanfilippo@....de> To: SF Markus Elfring <elfring@...rs.sourceforge.net>, netdev@...r.kernel.org, Mirko Lindner <mlindner@...vell.com>, Stephen Hemminger <stephen@...workplumber.org> Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org Subject: Re: [PATCH] sky2: Use seq_putc() in sky2_debug_show() Hi, On 08.05.2017 18:42, SF Markus Elfring wrote: > From: Markus Elfring <elfring@...rs.sourceforge.net> > Date: Mon, 8 May 2017 18:38:17 +0200 > > A single character (line break) should be put into a sequence. Why? > Thus use the corresponding function "seq_putc". > > This issue was detected by using the Coccinelle software. Which issue do you mean? I dont see any issue you fix here. > > Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net> > --- > drivers/net/ethernet/marvell/sky2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c > index 1145cde2274a..73575101cd72 100644 > --- a/drivers/net/ethernet/marvell/sky2.c > +++ b/drivers/net/ethernet/marvell/sky2.c > @@ -4562,7 +4562,7 @@ static int sky2_debug_show(struct seq_file *seq, void *v) > seq_printf(seq, "[%d] %#x %d %#x\n", > idx, le->opcode, le->length, le->status); > } > - seq_puts(seq, "\n"); > + seq_putc(seq, '\n'); > } > > seq_printf(seq, "Tx ring pending=%u...%u report=%d done=%d\n", > Regards, Lino
Powered by blists - more mailing lists