netdev - Re: [PATCH v2] vlan: Keep NETIF_F_HW_CSUM similar to other software devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170508.143936.2240195935826274116.davem@davemloft.net>
Date:   Mon, 08 May 2017 14:39:36 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     vyasevich@...il.com
Cc:     netdev@...r.kernel.org, mkubecek@...e.cz,
        alexander.duyck@...il.com, avagin@...nvz.org, vyasevic@...hat.com
Subject: Re: [PATCH v2] vlan: Keep NETIF_F_HW_CSUM similar to other
 software devices

From: Vladislav Yasevich <vyasevich@...il.com>
Date: Fri,  5 May 2017 16:17:41 -0400

> Vlan devices, like all other software devices, enable
> NETIF_F_HW_CSUM feature.  However, unlike all the othe other
> software devices, vlans will switch to using IP|IPV6_CSUM
> features, if the underlying devices uses them.  In these situations,
> checksum offload features on the vlan device can't be controlled
> via ethtool.
> 
> This patch makes vlans keep HW_CSUM feature if the underlying
> device supports checksum offloading.  This makes vlan devices
> behave like other software devices, and restores control to the
> user.
> 
> A side-effect is that some offload settings (typically UFO)
> may be enabled on the vlan device while being disabled on the HW.
> However, the GSO code will correctly process the packets. This
> actually results in slightly better raw throughput.
> 
> Signed-off-by: Vladislav Yasevich <vyasevic@...hat.com>
> ---
> V2:  posted the right patch.

Applied, thanks.