lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 9 May 2017 16:25:07 +0200 From: SF Markus Elfring <elfring@...rs.sourceforge.net> To: linux-hams@...r.kernel.org, netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Javier Martinez Canillas <javier@....samsung.com>, Jean-Paul Roubelat <jpr@...bb.org> Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org Subject: [PATCH 4/4] hamradio: Adjust four function calls together with a variable assignment From: Markus Elfring <elfring@...rs.sourceforge.net> Date: Tue, 9 May 2017 15:57:17 +0200 The script "checkpatch.pl" pointed information out like the following. ERROR: do not use assignment in if condition Thus fix affected source code places. Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net> --- drivers/net/hamradio/bpqether.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/net/hamradio/bpqether.c b/drivers/net/hamradio/bpqether.c index eaa0f2e8e561..5e234e0ca256 100644 --- a/drivers/net/hamradio/bpqether.c +++ b/drivers/net/hamradio/bpqether.c @@ -185,7 +185,8 @@ static int bpq_rcv(struct sk_buff *skb, struct net_device *dev, struct packet_ty if (!net_eq(dev_net(dev), &init_net)) goto drop; - if ((skb = skb_share_check(skb, GFP_ATOMIC)) == NULL) + skb = skb_share_check(skb, GFP_ATOMIC); + if (!skb) return NET_RX_DROP; if (!pskb_may_pull(skb, sizeof(struct ethhdr))) @@ -286,7 +287,8 @@ static netdev_tx_t bpq_xmit(struct sk_buff *skb, struct net_device *dev) bpq = netdev_priv(dev); orig_dev = dev; - if ((dev = bpq_get_ether_dev(dev)) == NULL) { + dev = bpq_get_ether_dev(dev); + if (!dev) { orig_dev->stats.tx_dropped++; kfree_skb(skb); return NETDEV_TX_OK; @@ -565,12 +567,14 @@ static int bpq_device_event(struct notifier_block *this, break; case NETDEV_DOWN: /* ethernet device closed -> close BPQ interface */ - if ((dev = bpq_get_ax25_dev(dev)) != NULL) + dev = bpq_get_ax25_dev(dev); + if (dev) dev_close(dev); break; case NETDEV_UNREGISTER: /* ethernet device removed -> free BPQ interface */ - if ((dev = bpq_get_ax25_dev(dev)) != NULL) + dev = bpq_get_ax25_dev(dev); + if (dev) bpq_free_device(dev); break; default: -- 2.12.2
Powered by blists - more mailing lists