netdev - Re: sky2: Use seq_putc() in sky2_debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170508225012.508f24c0@xeon-e3>
Date:   Mon, 8 May 2017 22:50:12 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     Lino Sanfilippo <LinoSanfilippo@....de>, netdev@...r.kernel.org,
        Mirko Lindner <mlindner@...vell.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: sky2: Use seq_putc() in sky2_debug_show()

On Mon, 8 May 2017 19:42:46 +0200
SF Markus Elfring <elfring@...rs.sourceforge.net> wrote:

> > Which issue do you mean? I dont see any issue you fix here.  
> 
> Are the run time characteristics a bit nicer for the function “seq_putc”
> in comparison to the function “seq_puts” for printing a single line break here?
> 
> Regards,
> Markus

I would put this in why bother category. seq_puts is correct and this is only
in diagnostic output useful to developer and disabled on most distro kernels