netdev - Re: [PATCH RFC net-next 3/6] net: Introduce IFF_LWT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52621c1c-57c4-efb7-80dc-648a0da7ae7f@gmail.com>
Date:   Mon, 8 May 2017 17:57:16 -0700
From:   David Ahern <dsahern@...il.com>
To:     David Miller <davem@...emloft.net>, johannes@...solutions.net
Cc:     netdev@...r.kernel.org, roopa@...ulusnetworks.com,
        f.fainelli@...il.com, nicolas.dichtel@...nd.com
Subject: Re: [PATCH RFC net-next 3/6] net: Introduce IFF_LWT_NETDEV flag

On 5/8/17 1:11 PM, David Miller wrote:
> From: Johannes Berg <johannes@...solutions.net>
> Date: Mon, 08 May 2017 10:55:12 +0200
> 
>>
>>> +static inline bool netif_is_lwd(struct net_device *dev)
>>> +{
>>> +	return !!(dev->priv_flags & IFF_LWT_NETDEV);
>>> +}
>>
>> Am I the only one who thinks that this "LWT_NETDEV" vs "LWD" is a bit
>> confusing?
> 
> Agreed, my old eyes can't discern them at a distance :-)
> 

perhaps it is the tiny font your old eyes are having trouble with :-)

I am fine with Johannes' suggestion -- just spell it out:
    netif_is_lwt_netdev

where lwt = LightWeighT