netdev - Re: [PATCH v2 1/7] bpf: Track alignment of register values in the verifier.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <06d46f08-2c62-d167-1fe5-a49284c614bb@fb.com>
Date:   Thu, 11 May 2017 15:53:06 -0700
From:   Alexei Starovoitov <ast@...com>
To:     David Miller <davem@...emloft.net>, <daniel@...earbox.net>
CC:     <alexei.starovoitov@...il.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 1/7] bpf: Track alignment of register values in the
 verifier.

On 5/11/17 9:05 AM, David Miller wrote:
> +		had_id = (dst_reg->id != 0);
> +
>  		/* dst_reg stays as pkt_ptr type and since some positive
>  		 * integer value was added to the pointer, increment its 'id'
>  		 */
>  		dst_reg->id = ++env->id_gen;
>
> -		/* something was added to pkt_ptr, set range and off to zero */
> +		/* something was added to pkt_ptr, set range to zero */
> +		dst_reg->aux_off = dst_reg->off;

what about 2nd addition of a variable to pkt_ptr ?
aux_off sort-of remembers already accumulated offset in pkt_ptr, but
above line will hard assign it which doesn't seem right for the 2nd
addition.
Ex:
before first add, reg->off == 14
after first add, aux_off = 14, off = 0
then imm4 added, now we have reg->off=4, aux_off=14
now we do 2nd add of variable and
reg->aux_off becomes 4
and if we later do u64 load from the packet it will be rejected
due to (net_ip_align + 4) whereas it should have been ok
due to (net_ip_align + 14 + 4).

>  		dst_reg->off = 0;
>  		dst_reg->range = 0;
> +		if (had_id)
> +			dst_reg->aux_off_align = min(dst_reg->aux_off_align,
> +						     src_reg->min_align);
> +		else
> +			dst_reg->aux_off_align = src_reg->min_align;

all aux_off_align logic here and in other places looks fine to me,
since it's conservative.