netdev - Re: [PATCH] ethernet: aquantia: remove redundant checks on error status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <174d4afe-16a8-cd2d-9be9-0f502cc89a59@canonical.com>
Date:   Thu, 11 May 2017 19:18:08 +0100
From:   Colin Ian King <colin.king@...onical.com>
To:     David Miller <davem@...emloft.net>
Cc:     pavel.belous@...antia.com, Dmitrii.Tarakanov@...antia.com,
        Alexander.Loktionov@...antia.com, vomlehn@...as.net,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ethernet: aquantia: remove redundant checks on error
 status

On 11/05/17 19:16, David Miller wrote:
> From: Colin King <colin.king@...onical.com>
> Date: Thu, 11 May 2017 18:29:29 +0100
> 
>> From: Colin Ian King <colin.king@...onical.com>
>>
>> The error status err is initialized as zero and then being checked
>> several times to see if it is less than zero even when it has not
>> been updated. Since these checks are redundant we can remove these
>> as well as err and the error exit label err_exit.
>>
>> Detected by CoverityScan, CID#1398313 and CID#1398306 ("Logically
>> dead code")
>>
>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> 
> Please enhance your commit message to also explain that the functions
> being called around these checks all return void, to make it clear
> that this isn't an issue of the return values not being checked.
> 
> Thanks.
> 
Good idea. Will do.