netdev - Re: [PATCH net] net: sched: optimize class dumps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170511.213804.55365186660390823.davem@davemloft.net>
Date:   Thu, 11 May 2017 21:38:04 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, jkosina@...e.cz, jhs@...atatu.com,
        xiyou.wangcong@...il.com, jiri@...nulli.us
Subject: Re: [PATCH net] net: sched: optimize class dumps

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 10 May 2017 21:59:28 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> In commit 59cc1f61f09c ("net: sched: convert qdisc linked list to
> hashtable") we missed the opportunity to considerably speed up
> tc_dump_tclass_root() if a qdisc handle is provided by user.
> 
> Instead of iterating all the qdiscs, use qdisc_match_from_root()
> to directly get the one we look for.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks Eric.