netdev - Re: [PATCH] mdio: mux: fix device_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170512.122223.341607427763777325.davem@davemloft.net>
Date:   Fri, 12 May 2017 12:22:23 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     julia.lawall@...6.fr
Cc:     netdev@...r.kernel.org, jon.mason@...adcom.com, andrew@...n.ch,
        f.fainelli@...il.com, kbuild-all@...org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mdio: mux: fix device_node_continue.cocci warnings

From: Julia Lawall <julia.lawall@...6.fr>
Date: Fri, 12 May 2017 22:54:23 +0800 (SGT)

> Device node iterators put the previous value of the index variable, so an
> explicit put causes a double put.
 ...
> @@ -169,7 +169,6 @@ int mdio_mux_init(struct device *dev,
>  		if (r) {
>  			mdiobus_free(cb->mii_bus);
>  			devm_kfree(dev, cb);
> -			of_node_put(child_bus_node);
>  		} else {

I think we're instead simply missing a break; statement here.