lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20170512.133446.1511184455056119469.davem@davemloft.net> Date: Fri, 12 May 2017 13:34:46 -0400 (EDT) From: David Miller <davem@...emloft.net> To: dsahern@...il.com Cc: mq@....cz, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, dsa@...ulusnetworks.com, kuznet@....inr.ac.ru, jmorris@...ei.org, yoshfuji@...ux-ipv6.org, kaber@...sh.net Subject: Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer. From: David Ahern <dsahern@...il.com> Date: Fri, 12 May 2017 10:26:08 -0700 > On 5/12/17 8:24 AM, David Miller wrote: >> From: Jan Moskyto Matejka <mq@....cz> >> Date: Fri, 12 May 2017 13:15:10 +0200 >> >>> -int rt6_dump_route(struct rt6_info *rt, void *p_arg); >>> +int rt6_dump_route(struct rt6_info *rt, void *p_arg, int truncate); >> >> Please use "bool" and "true"/"false" for boolean values. >> >> What does ipv4 do in this situation? >> >> I'm hesitant to be OK with adding a new nlmsg flag just for this case >> if we solve this problem differently and using existing mechanisms >> elsewhere. >> > > I'll take a look at this later today or this weekend; we can't just > truncate the route returned to userspace. Agreed.
Powered by blists - more mailing lists