lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20170515002531.GG14058@lunn.ch> Date: Mon, 15 May 2017 02:25:31 +0200 From: Andrew Lunn <andrew@...n.ch> To: Maciek Fijalkowski <macfij7@...pl> Cc: mst@...hat.com, jasonwang@...hat.com, virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/3] Fix ERROR: Macros with complex values should be enclosed in parentheses On Sun, May 14, 2017 at 07:51:29PM +0200, Maciek Fijalkowski wrote: > From: Maciej Fijalkowski <macfij7@...pl> Hi Maciek Please include some commit message, even if it is just the checkpatch error you are fixing. Please include the subsystem/driver you are patch in the subject line. Also, your subject of Fix ERROR: makes it sound a lot worse than it is. net: virtio: Fix checkpatch error Complex macros should use () Also, you should at least compile test your change. It is clearly wrong, as shown by 0-day. Andrew
Powered by blists - more mailing lists