netdev - Re: [net 1/6] net/mlx5e: Use a spinlock to synchronize statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170515.143948.1759849420537263846.davem@davemloft.net>
Date:   Mon, 15 May 2017 14:39:48 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     saeedm@....mellanox.co.il
Cc:     saeedm@...lanox.com, netdev@...r.kernel.org, galp@...lanox.com,
        kernel-team@...com
Subject: Re: [net 1/6] net/mlx5e: Use a spinlock to synchronize statistics

From: Saeed Mahameed <saeedm@....mellanox.co.il>
Date: Sun, 14 May 2017 11:52:13 +0300

> I agree, it is really ridiculous that we allocate/free a couple of
> buffers on each update_stats operations, regardless of this patch.
> Is it ok if we use a temp buffer under netdev_priv for such usages or
> even use kmemcache ?

If you can safely use a pre-allocated tmp buffer, yes that would be
preferred.