lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20170515055700-mutt-send-email-mst@kernel.org> Date: Mon, 15 May 2017 05:58:05 +0300 From: "Michael S. Tsirkin" <mst@...hat.com> To: Maciek Fijalkowski <macfij7@...pl> Cc: jasowang@...hat.com, virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/3] Fix ERROR: trailing statements should be on next line On Sun, May 14, 2017 at 07:51:28PM +0200, Maciek Fijalkowski wrote: > From: Maciej Fijalkowski <macfij7@...pl> > > Signed-off-by: Maciej Fijalkowski <macfij7@...pl> I prefer the original form - ; isn't a full statement. > --- > drivers/net/virtio_net.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index 9320d96..f20dfb8 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -217,7 +217,8 @@ static void give_pages(struct receive_queue *rq, struct page *page) > struct page *end; > > /* Find end of list, sew whole thing into vi->rq.pages. */ > - for (end = page; end->private; end = (struct page *)end->private); > + for (end = page; end->private; end = (struct page *)end->private) > + ; > end->private = (unsigned long)rq->pages; > rq->pages = page; > } > -- > 2.4.11
Powered by blists - more mailing lists